FIX: Middleware routing stuck at page #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 3, 2025 21:21
… reliable redirection after sign-in and sign-out
…ction logic and prevent redirect loops
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Summary
This pull request includes several changes to improve the reliability of redirection and handling of authenticated routes in the application. The changes focus on ensuring proper authentication state detection and avoiding redirect loops.
Improvements to redirection:
store/AuthStore/useAuthStore.ts: Replacedrouter.pushwithwindow.location.hreffor redirection after login and logout to ensure the middleware properly detects the authentication state. [1] [2]Enhancements to authentication middleware:
utils/supabase/middleware.ts: Added a check to redirect unauthenticated users to the signin page when accessing protected routes.utils/supabase/middleware.ts: Implemented a mechanism to redirect authenticated users away from auth pages by adding a cache-busting parameter to avoid redirect loops.